DanielLeens commented on PR #12650: URL: https://github.com/apache/seatunnel/pull/12650#issuecomment-6397818768
Thanks for the contribution. The CI/merge fact in my previous review has changed. The exact-head [fork Build](https://github.com/SEPURI-SAI-KRISHNA/seatunnel/actions/runs/39911769065) is now **completed with failure** for `43f670a47de9993225bd9c7f6786c7cc81704b30`. This is a gate correction, not a second full source review of that unchanged head. The old statement that the fork run was queued with nothing failing is obsolete. I inspected all three failed job logs: - [Java 11 UT](https://github.com/SEPURI-SAI-KRISHNA/seatunnel/actions/runs/39911769065/job/120303832001): `SavePointTest.testSavePointButJobGoingToFail` waits for RUNNING but sees FAILED for two minutes. - [Elasticsearch Java 11 IT](https://github.com/SEPURI-SAI-KRISHNA/seatunnel/actions/runs/39911769065/job/120303833336): the encoded-API-key test cannot create its Flink container because Docker Hub auth/manifest retrieval times out, before its connector assertion. - [Google Pub/Sub Java 11 IT](https://github.com/SEPURI-SAI-KRISHNA/seatunnel/actions/runs/39911769065/job/120303833364): `testGooglePubSubSourceAcknowledgesAfterCheckpoint` times out on its future at line 228. Later teardown logs also contain a shaded Netty class-loading error; they do not establish the cause of the earlier timeout. These failures do not directly implicate the Arrow batch-index repair. The SavePoint and Pub/Sub test files are unchanged in latest dev; I found no demonstrated matching fix there. A sync alone cannot be promised to solve them. The low-cost next step is targeted reruns of these three failed jobs after registry access recovers, keeping each failure separate if it repeats. Please do not modify the Arrow conversion or add unrelated dependencies to chase these signatures. Comparison against dev is `diverged`, ahead 8 / behind 24; merge conflicts: no. Drift is recorded independently and does not itself justify a sync request. No new source-level blocker from my previous full review is asserted here; a successful required Build and write-capable maintainer approval remain separate gates. Daniel has READ permission, so this comment is not an effective approval. Thanks for keeping the fix focused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
