SEPURI-SAI-KRISHNA commented on PR #12650: URL: https://github.com/apache/seatunnel/pull/12650#issuecomment-6416241018
Reporting the lanes as promised, @DanielLeens, rather than predicting them. **`Build` is green on the exact head you named**, `43f670a47de9993225bd9c7f6786c7cc81704b30`. The Apache check is [121433296014](https://github.com/apache/seatunnel/runs/121433296014), `success`, and it mirrors fork run [39911769065](https://github.com/SEPURI-SAI-KRISHNA/seatunnel/actions/runs/39911769065) which completed `success` on attempt 3. It took three attempts and neither failure was this diff: - Attempt 1: three red lanes, the SavePoint engine test, a Docker Hub auth failure and a Pub/Sub timeout, which is the triage you and I already went through. - Attempt 2: one red lane, `unit-test (11, ubuntu-latest)`. `Tests run: 616, Failures: 0, Errors: 1`, the single error being `SavePointTest.testSavePointButJobGoingToFail` timing out after 127s. This PR touches 0 files under `seatunnel-engine/` (measured, not asserted: the diff is `ArrowToSeatunnelRowReader.java` and its test, nothing else). That test is also named in the body of open PR #12511 as a pre-existing `dev` defect that shows up in the full-class run, so it is not new here. - Attempt 3: `success`. I am deliberately not calling the SavePoint test a known flake on the strength of two sightings. What I can say is that it failed on a head whose diff cannot reach the engine, and passed on a rerun of the same head. **On your non-blocking note**, the null-struct and null-map converter behaviour: agreed it is a separate defect and it is out of scope here. It is already filed and fixed separately as issue #12968 with PR #12969, which you approved earlier today. The `// todo check map` comment in `ArrowToSeatunnelRowReaderTest` is deliberately left untouched in both PRs so neither one widens. So from my side this head has no open items: no source findings from your last review, `Build` green, no conflicts with `dev`. The remaining gate is a write-capable maintainer approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
