DanielLeens commented on PR #12877: URL: https://github.com/apache/seatunnel/pull/12877#issuecomment-6397064777
One upstream-status correction to my previous CI guidance: #12875 was closed without merging. The JDBC option-fixture repair instead landed through #12938 (commit `cc54bb433357b4cb45db9cd5d0743589c3111b79`) and is already on latest dev. My earlier statement that dev was still waiting for #12875 is obsolete. The active gate on this head is still [workflow-run detection](https://github.com/apache/seatunnel/runs/117843054678): the current fork inventory contains no Build run for `4054727c8354f06537032654bbb74d9a65349fda`. The earlier HTTP 422 established disabled Actions at that time; if you have since enabled them, use the fork's Build > Run workflow on this branch so the existing head gets a result. No extra source commit is needed for a manual dispatch. If that run then hits the old numeric_special_value_as_null fixture failure, the merged #12938 is the relevant upstream repair; it is not a reason to add unrelated source patches here. I am not asking for a sync solely because this branch is behind. Good job. Thanks a lot for your valuable contribution to Apache SeaTunnel! To pass the automated CI checks for this PR, could you please enable CI workflows in your forked repository first? You can refer to the check run link below as a reference for the required CI configuration https://github.com/apache/seatunnel/runs/117843054678 If you run into any trouble enabling CI or encounter related errors during the process, feel free to leave a comment here. Contributors are always ready to offer help~ <img width="2412" height="1472" alt="image" src="https://github.com/user-attachments/assets/6abd2ea1-da45-4d78-a81c-0158f2d7a851"; /> My source-level conclusion is unchanged: no outstanding Daniel source blocker, with an acceptable exact-head CI result and write-capable maintainer approval still required. This follow-up corrects upstream/CI guidance; it is not another full review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
