DanielLeens commented on issue #12620: URL: https://github.com/apache/seatunnel/issues/12620#issuecomment-6397375791
Thanks for re-running the scan and separating the two kinds of locale dependence. The updated result gives us a narrower sequence: #12618 has removed the 11 non-SQL bare case conversions; the remaining 13 SQL sites are covered by the still-open #12495. Its current Build is failing, so the zero-site baseline is not established on `dev` yet. For this guard, I agree with an explicit, fixed locale for case conversion. #11994 leaves no demonstrated user-data exception in this module. Please re-run the full `seatunnel-transforms-v2/src/main` scan after #12495 merges, record the exact zero baseline in a focused test, and make any deliberate exception explicit at its call site and in that test. That can use the existing test setup; this issue does not need a new style-check dependency or a broad regex CI rule before the contract is proven. Keep text-producing/parsing date patterns as separate behavioral work: #12975/#12976 covers the existing formatter calls, while #12703 has the new shared formatter/parse path and a specific follow-up review. `ZetaDateTimeFormat`'s numeric-only patterns do not justify a blanket formatter ban. Once those PRs settle, please update this issue with the new `dev` commit and scan result, including any actual exceptions, so the guard tests the code we will maintain rather than the earlier 24-site snapshot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
