SEZ9 commented on issue #12612: URL: https://github.com/apache/seatunnel/issues/12612#issuecomment-6432041111
Thanks for closing the loop on both, @SEPURI-SAI-KRISHNA. **1.** Agreed — the release-notes entry already names `COALESCE` / `IFNULL` as the route by which a `DECIMAL` or `DOUBLE` reaches a `BIGINT` target, in both EN and ZH, so nothing further is needed there. **2.** Thanks for measuring it rather than asserting it. The three-row table (`COALESCE(int_col, bigint_col)` → `INT`, the `CAST`-wrapped `COALESCE` and `IFNULL` → `BIGINT`) is exactly the evidence I wanted behind the Migration Guide line, and the concrete `COALESCE(CAST(int_col AS BIGINT), bigint_col)` example in both languages is sufficient. **3.** On the `IFNULL` signature correction: since it is documentation only, EN and ZH, with no production or test change, and it directly supports the "first argument wins" story the migration note relies on, I am fine with it staying in the same change rather than a separate PR. Putting the workaround under the `COALESCE` and `IFNULL` sections themselves, not only under `CAST`, is the right call for discoverability. I will take another look once the documentation changes are pushed. <!-- streview-comment:2060 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
