SEPURI-SAI-KRISHNA commented on issue #12612: URL: https://github.com/apache/seatunnel/issues/12612#issuecomment-6434337191
@SEZ9 the documentation changes are pushed, so #12899 is ready for that second look. They went up as `275efb97b`, which is documentation only: 4 files, `+21/-3`, no production or test change. The current head of #12899 is `639908b12`, and I have just verified all four files on that exact head rather than on my local copy: | what | where | | --- | --- | | `IFNULL` signature corrected to `type(of first non-null arg)` | EN `sql-functions.md:1299`, ZH `:1296` | | `COALESCE` signature, same form | EN `:1279`, ZH `:1276` | | Workaround in the `COALESCE` and `IFNULL` sections themselves | EN `:1283` and `:1303`, ZH `:1280` and `:1300` | | `COALESCE(CAST(int_col AS BIGINT), bigint_col)` in the Migration Guide | EN `incompatible-changes.md:178`, ZH `:157` | So the signature correction, the per-section workaround and the Migration Guide line are all present in both languages. Each of those workaround paragraphs also carries the caveat that came out of @DanielLeens's review, since it is the part most likely to bite: putting the wider argument first is the only remedy for a `DECIMAL` or `DOUBLE`, because no cast to `BIGINT` exists for them, but reordering is not a drop-in change, as it also changes which argument wins when both are non-null. **One thing you should know before you look, because the Build badge is currently red.** It is not a test failure. The `all-connectors-it-3` lane hit a time cap on both JDKs: | head | JDK 11 | JDK 17 | | --- | --- | --- | | `275efb97b` | passed in 112m | passed in 112m | | `639908b12` | capped at 150m | capped at 150m | Same lane, same PR, one commit apart, and `639908b12` is the merge with `dev` rather than a content change. So this reads as runner variance against a lane that normally finishes with about 38 minutes of headroom. I have rerun it and will report the result here rather than assume it. `#12899` is `MERGEABLE` with no conflict, re-checked after `dev` moved to `c875a87bd` today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
