SEPURI-SAI-KRISHNA commented on PR #13014: URL: https://github.com/apache/seatunnel/pull/13014#issuecomment-6437103324
@nzw921rx apologies for the noise. I opened this after you had already closed #12620 and I simply had not seen the close. It is now in draft, so it is out of your review queue. Before I close it, would you mind saying which part you do not want? It would stop me repeating the mistake: 1. the contract guard as an idea, 2. this implementation of it, a source scan living in `seatunnel-ci-tools`, or 3. the locale-contract line of work on `transforms-v2` generally. For context rather than as an argument: @SEZ9 asked for this test on #12620 earlier the same morning, with four specific requirements, which is why I built it. If that was not sufficient grounds to proceed, knowing that is genuinely useful to me going forward. Happy to close straight away if it is simply not wanted. The underlying fixes (#12618 and #12495) are already merged, so dropping the guard costs nothing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
