fatmanverse commented on PR #12920:
URL: https://github.com/apache/seatunnel/pull/12920#issuecomment-6458700806
Thanks @DanielLeens. Your review was on `5fef05b3`; the three blockers are
already in the current head `c296b64` (pushed a few minutes after your review,
see my comment above):
1. `SQLNumericComparisonTest#preservesDecimalCastScaleRounding` now expects
the half-away-from-zero results (`CAST('1.231' ...)` = `1.23`, `CAST('-1.239'
...)` = `-1.24`, plus `-CAST('1.239' ...)` = `-1.24`).
2. The CEILING statements that #12318 added are updated in
`docs/en|zh/transforms/sql.md` and in #12318's entry of
`incompatible-changes.md` (en/zh).
3. `dev` is merged (e8fddb7, conflict-free on top of @zhiweiniu's merge),
and the PR shows no conflict.
On the non-blocking item: `func_system.conf` casts the STRING `"12.4"` with
`cast(c1 as DECIMAL(10,2))` and expects `"12.40"`. That cast only adds a digit
and drops none, so the rounding mode does not apply and the expectation is
unaffected.
On JDK 17, `./mvnw -pl seatunnel-transforms-v2 test` on `c296b64` passes:
1864 tests, 0 failures (18 skipped). The fork `Build` for `c296b64` is queued.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
