fatmanverse commented on PR #12920:
URL: https://github.com/apache/seatunnel/pull/12920#issuecomment-6457577628
@zhiweiniu thanks for merging `dev` into the branch. @DanielLeens, as you
flagged, #12318 merged first, so this PR now updates the lines it added.
c296b64 (on top of a conflict-free merge of the latest `dev`, e8fddb7):
- `SQLNumericComparisonTest#preservesDecimalCastScaleRounding`:
`CAST('1.231' AS DECIMAL(10, 2))` now expects `1.23` (was `1.24`) and
`CAST('-1.239' AS DECIMAL(10, 2))` expects `-1.24` (was `-1.23`). I added
`-CAST('1.239' AS DECIMAL(10, 2))` = `-1.24`, since negating before or after
CAST now gives the same result. The two numeric-literal cases were already
`HALF_UP` and are unchanged.
- `docs/en|zh/transforms/sql.md` (Numeric comparisons): replaced "Existing
CAST rounding is unchanged ... uses `CEILING`" with the half-away-from-zero
rule and the same examples, and dropped the "the two forms are not
interchangeable" note, which no longer holds.
- `incompatible-changes.md` (en/zh), #12318's entry: the "Existing CAST
rounding is unchanged: ... `CEILING`" sentence now points to this PR's entry
and says negation before or after CAST gives the same result.
On JDK 17, `./mvnw -pl seatunnel-transforms-v2 test` passes: 1864 tests, 0
failures (18 skipped), including `SQLNumericComparisonTest` (360) and
`SystemFunctionTest` (27).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
