DanielLeens commented on PR #12293: URL: https://github.com/apache/seatunnel/pull/12293#issuecomment-6473856367
Thanks @SEZ9. The F1-F8 checklist refers to earlier points; my latest complete review on cb4dfdcec84d already checked the trimming, HNS prerequisite, synchronized documentation and denylist responses, while leaving your own thread decisions to you. The remaining numbered blocker from my review is the new duplicate-property E2E: its optional substitutions and command-line overrides do not reach the intended configuration, so it fails at the authority check instead. Please fix that test with an actually exercised override path; green unrelated lanes would not resolve it. There is no need to reopen already addressed production points without current-head counterevidence. Gate snapshot (2026-10-28T15:56:15+00:00), head `cb4dfdcec84d7112c9c0f739bedfebe8362114ba`: [Build](https://github.com/apache/seatunnel/runs/122617919792) is `FAILURE`. The blocking jobs are [Run / unit-test (11, windows-latest)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/actions/runs/40548996817/job/122349070175) `failure`; [Run / unit-test (17, windows-latest)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/actions/runs/40548996817/job/122349070257) `failure`; [Run / all-connectors-it-1 (11, ubuntu-latest)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/actions/runs/40548996817/job/122349071183) `failure`; [Run / all-connectors-it-1 (17, ubuntu-latest)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/actions/runs/40548996817/job/122349071449) `failure`; [Run / all-connectors-it-3 (17, ubuntu-latest)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/actions/runs/40548996817/job/122349071575) `cancelled`; [Run / jdbc-connectors-it-part-7 (11, ubuntu-latest)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/actions/runs/40548996817/job/122349071928) `failure`; [Run / connector- file-local-it (17, ubuntu-latest)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/actions/runs/40548996817/job/122349072267) `cancelled`. Observed log evidence: `Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.22.2:verify (default) on project connector-file-adls-e2e: There are test failures.` Please inspect or rerun only the named failed job where a rerun is appropriate. The logs establish the failing stage, but do not alone establish whether the current PR caused it. No matching upstream cure has been proved by this follow-up; a base sync alone is not a verified resolution, so no unrelated module/dependency patch is requested. My [previous source conclusion](https://github.com/apache/seatunnel/pull/12293#pullrequestreview-5676323200) remains unchanged, including its independent source/documentation requests. CI is not being passed by inference, and this follow-up is not an effective approval. Comparison recorded in this scan: base `dev`, `diverged`, ahead 93 / behind 14, no merge conflict. Branch drift is metadata here and is not an additional sync request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
