SEZ9 commented on PR #12293: URL: https://github.com/apache/seatunnel/pull/12293#issuecomment-6459235847
@sudeephazra thanks for the detailed rundown on c73710b129231d71026bfaa513b7abb862788c77, and sorry for the slow reply. **PR12293-F1 (whitespace normalization)** – What you describe resolves the finding: trimming both key and value in `ADLSHadoopConf` (`options.put(key.trim(), value.trim())`), rejecting keys that are blank after trimming, and covering it with the padded key/value assertions in `ADLSHadoopConfTest` plus `ADLSConfigValidatorTest.rejectsBlankAdvancedPropertyKeys()`. Having the en/zh docs state the behavior is exactly what I wanted. I'll mark F1 as addressed once I've had a quick look at those two tests on the PR branch. **PR12293-F2 (HNS requirement in the sink docs)** – Your comment appears to have been cut off mid‑sentence at "HNS and same-container rename prerequisi…", so I don't actually have your answer for this one. Could you repost that part? Specifically, I'd like to confirm that `docs/en/connectors/sink/ADLSFile.md` (and the zh counterpart) now state that hierarchical namespace must be enabled and that `tmp_path` and `path` must live in the same container for the rename-based commit to be atomic. **Remaining findings** – I didn't see anything in the comment about PR12293-F3 through PR12293-F8 (undocumented validation rules / template placeholders, OAuth `authority_host`/`tenant_id` validation, option-table drift, the `account_key` mask-list change, the `discovery_mode`/`start_mode` defaults in the English source doc, and the ABFS denylist gaps). If those were in the truncated part, a short status line per finding — fixed in this commit, still pending, or disagree with reasoning — would be great. If they are still open, let me know whether you plan to handle them in this PR or as follow-ups. Once I have the F2 confirmation and the status for F3–F8 I'll do another pass. <!-- streview-comment:2084 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
