corgy-w commented on code in PR #13054:
URL: https://github.com/apache/seatunnel/pull/13054#discussion_r4420346284
##########
seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/JdbcOutputFormatReconnectTest.java:
##########
@@ -19,16 +19,21 @@
import org.apache.seatunnel.api.table.type.SeaTunnelRow;
import
org.apache.seatunnel.connectors.seatunnel.jdbc.config.JdbcConnectionConfig;
+import
org.apache.seatunnel.connectors.seatunnel.jdbc.exception.JdbcConnectorException;
import
org.apache.seatunnel.connectors.seatunnel.jdbc.internal.connection.JdbcConnectionProvider;
+import
org.apache.seatunnel.connectors.seatunnel.jdbc.internal.connection.JdbcTransactionStateManager;
import
org.apache.seatunnel.connectors.seatunnel.jdbc.internal.executor.JdbcBatchStatementExecutor;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.CsvSource;
import org.mockito.Mockito;
import java.sql.BatchUpdateException;
import java.sql.Connection;
import java.sql.SQLException;
+import java.util.Optional;
/** Tests JDBC output retry decisions for nested SQLExceptions thrown by batch
execution. */
public class JdbcOutputFormatReconnectTest {
Review Comment:
The current AI-generated UTs feel somewhat verbose and redundant. Please
review them manually, ensure each test covers a distinct behavior, and
consolidate overlapping scenarios while preserving the key transaction-safety
coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
