DanielLeens commented on PR #12397: URL: https://github.com/apache/seatunnel/pull/12397#issuecomment-6557471231
Thanks @SEZ9. These points are already present on the unchanged head, rather than work awaiting another push. `SeaTunnelArrayType.java:25-55` documents allocation ownership and the parser/API class limitations. Its `setElement` catches ArrayStoreException and reports index, declared type and expected/actual runtime classes without the payload; the helper does not add field/table identifiers. My prior review overstated that part of the diagnostic, and I am correcting it here. `NestedArrayConverterTest.java:92-126` covers malformed internal and external array elements and checks the declared/runtime classes without payload values. All reverse array paths use this helper. `TypeConverterUtils.java:182-186` explicitly records the physical Long/Decimal fallback and the inability to recover logical TIME/TIMESTAMP_TZ metadata from an array element. The EN/ZH migration entry records the null-map-element consumer risk and module identity, and the Spark reference pages describe current supported arrays separately from the FakeSource construction limitation. These were included in my complete current-head review. The bare ArrayStoreException concern is addressed; adding field/table identifiers remains useful diagnostic enrichment rather than a data-conversion blocker. I keep the source-clear conclusion while explicitly preserving that distinction. Current-head Build remains green; any final repository approval is still a maintainer action. Checked 2026-11-01T11:43:24.655910+00:00; unchanged head `5a5f78a717f19f84bbf04d4bb53f9903c3a7e2da`, base `dev`; compare `diverged`, ahead 17 / behind 9; merge `dirty` / `DIRTY`; review decision `REVIEW_REQUIRED`. Behind/diverged is recorded independently and does not itself request a sync. Daniel has READ repository permission. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
