goutamadwant commented on PR #12397: URL: https://github.com/apache/seatunnel/pull/12397#issuecomment-6651163578
Thanks @SEZ9. All of these are on the current head `d289489598`; there is no pending push. 1. `reconvertArray`: all three overloads store through `SeaTunnelArrayType.setElement` (`InternalRowConverter.java:354`, `:364`; `SeaTunnelRowConverter.java:275`). It wraps `ArrayStoreException` with index, declared type and expected/actual class, without the value (`SeaTunnelArrayType.java:35-50`). Test: `NestedArrayConverterTest.java:94-131`. Field/table name is not included. 2. TIME/TIMESTAMP_TZ arrays: documented at `TypeConverterUtils.java:183-185`, tested at `NestedArrayConverterTest.java:309-327`, user docs at `docs/en/engines/spark.md:121`. 3. `SeaTunnelArrayType`: class Javadoc at `:25`, parser `MapType.class` defect at `:53-54`. I kept the name. 4. `runtimeClass`: `:53-55` covers both the parser case and the `LocalTimeType[]` constants. 5. `incompatible-changes.md`: module path at `:278`, NPE failure mode at `:286-287` (zh `:92`, `:98-99`). 6. `spark.md` Nested Arrays (`:111-121`, zh same lines): no "Previously" or PR-scope prose left. CI: the failed job passed on re-run, and Build is green. Is anything still open on your side? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
