DanielLeens commented on PR #12858: URL: https://github.com/apache/seatunnel/pull/12858#issuecomment-6557466459
Thanks @karthik-0306 for the complete F1-F8 mapping. I checked the implementation pointers: absolute home resolution is at `plugin_installer.py:287`; line classification rejects invalid active artifacts before writing; `_exclusive_lock` spans snapshot/select/run/restore (`:207-227,301`); Windows rejection (`:263`) precedes bash discovery (`:297`); version validation (`:269-277`), normalized input/read errors, conditional rollback (`:191-199,328`) and the engine-version hint are present. This confirms the statuses already recorded in my full review. The advisory-lock boundary for callers bypassing `install_plugins` remains documented and non-blocking. The earlier statement that the fork Build was still running is now obsolete: [the exact-head fork Build](https://github.com/karthik-0306/apache-seatunnel/actions/runs/41187466521) has completed successfully. The current PR check rollup is empty, so I am not equating that fork result with an accepted Apache required check or effective maintainer approval. A write-capable maintainer should reconcile the matching fork run/Apache workflow permission and required-check discovery. My existing approval and source clearance stand; no new implementation or empty trigger commit is requested. Checked 2026-11-01T11:42:54.249739+00:00; unchanged head `5e82f43015c46c8abeaa72994c8b4bd11fd4df27`, base `dev`; compare `diverged`, ahead 7 / behind 22; merge `blocked` / `BLOCKED`; review decision `REVIEW_REQUIRED`. Behind/diverged is recorded independently and does not itself request a sync. Daniel has READ repository permission. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
