DanielLeens commented on PR #12858: URL: https://github.com/apache/seatunnel/pull/12858#issuecomment-6514218083
Thanks @SEZ9. The complete Fix/Code/Tests replies are readable through the API; no repost is needed for my review. The current head already has `_restore_if_changed` at plugin_installer.py:191-199, Linux/macOS-only wording at :233-235 with the matching error, and engine-version-independent guidance at :268-277. The existing regression tests for unchanged-file restoration, Windows rejection and the version hint were included in the earlier exact-head recheck. My source conclusion remains clear. Build plus Python 3.9 and 3.13 checks are now SUCCESS, so the earlier Python-runner/workflow-approval guidance is superseded by those actual results. The remaining gate is effective approval by a write-capable maintainer; no additional installer patch or full-table repost is requested. Snapshot 2026-10-30T03:23:54.152060+00:00: head `1c42f78cbda1242d35ee6e546d993b4017b30a36`; [Signal pull request update](https://github.com/apache/seatunnel/actions/runs/40744539762/job/123330606583) = `SUCCESS`; [Test with Python 3.9](https://github.com/apache/seatunnel/actions/runs/40744539750/job/123852191108) = `SUCCESS`; [Test with Python 3.13](https://github.com/apache/seatunnel/actions/runs/40744539750/job/123852191355) = `SUCCESS`; [Build](https://github.com/apache/seatunnel/runs/123855764926) = `SUCCESS`. Base `dev`; comparison `diverged`, ahead 6, behind 9; merge state `blocked`. Behind/diverged alone is recorded metadata and does not add a sync request. This is an unchanged-head discussion/CI clarification, not a new complete source review, an effective approval or a dismissal of historical requested changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
