DanielLeens commented on PR #13070: URL: https://github.com/apache/seatunnel/pull/13070#issuecomment-6557750952
The CI fact in my [existing full review of this exact head](https://github.com/apache/seatunnel/pull/13070#pullrequestreview-5720642220) has changed. That source review is already published; this is a gate clarification, not another full source review on the same version. Source status: the existing VECTOR lexer comment-handling blocker remain open. CI progress does not clear those source requests. The [exact-head fork Build](https://github.com/DanielLeens/seatunnel/actions/runs/41157712939) is now `completed` / `failure`, attempt 1. Job conclusions: success=43, failure=4, skipped=31. The four JDK11/17 Ubuntu/Windows unit lanes are red. The inspected [JDK17 Ubuntu log](https://github.com/DanielLeens/seatunnel/actions/runs/41157712939/job/124410897044) has three concrete errors: two GtidUtilsTest cases pass A/B/C as GTID server identifiers, and the upgraded client rejects them as invalid UUIDs; the new CREATE VECTOR test dereferences a null vectorTable. CustomMySqlAntlrDdlParserListener.java:65-69 installs only the custom ALTER listener, so a CREATE statement is not a table-population fixture for this parser. Use valid UUID fixtures for the replaced client and test CREATE metadata through the parser/listener that actually captures it; keep the real ALTER/schema-event regression. These are PR-related test/dependency integration failures, not an upstream-sync cure. Sorry for mi ssing these fixture assumptions in the previous review; they were present in that version, not newly introduced by a later commit. The existing production lexer comment blocker remains separate. The current base comparison is recorded separately. Missing Apache check adoption is distinct from the fork conclusion, and neither is an effective independent approval. Daniel is the author and has READ repository permission. Checked 2026-11-01T12:10:46.439646+00:00; unchanged head `a1f31ae899525dfb5dd50ae1ae543a1ae7b0dc3f`, base `dev`; compare `diverged`, ahead 2 / behind 9; merge `blocked` / `BLOCKED`; review decision `REVIEW_REQUIRED`. Behind/diverged is recorded independently and does not itself request a sync. Daniel has READ repository permission. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
