DanielLeens commented on PR #13070: URL: https://github.com/apache/seatunnel/pull/13070#issuecomment-6593273733
Addressed in e926b0bd64 for [review 5720642220](https://github.com/apache/seatunnel/pull/13070#pullrequestreview-5720642220) and the [CI follow-up](https://github.com/apache/seatunnel/pull/13070#issuecomment-6557750952). **Issue 1 (comments after VECTOR):** fixed. `MySqlVectorTypeLexer` no longer peeks at raw characters. It finds the next default-channel token with the lexer's own rules and buffers anything it lexed ahead, returning it in order. Whitespace, `/* */`, `--`/`#` line comments and `/*! */` executable comments are therefore skipped exactly as the 1.9.8 grammar skips them (`SPACE`, `COMMENT_INPUT`, `LINE_COMMENT` → `HIDDEN`, `SPEC_MYSQL_COMMENT` → `MYSQLCOMMENT`). The parser tests now include `VECTOR /* dimension */ (3)`, a `--` line comment before `DEFAULT NULL`, and an ALTER with a block comment before `(4)`. Identifier-named-`vector` cases are kept. **Issue 2:** the statement-state fields now carry a comment describing their transitions. `testMysqlCdcVectorColumn` keeps the job future. If the streaming job ends early, the bounded wait stops immediately with the job's cause instead of polling until timeout. **Unit-test failures on a1f31ae (4 lanes):** - `GtidUtilsTest` (2 errors): the new client parses GTID server IDs with `UUID.fromString` (confirmed in `GtidSet.java` at v0.40.2), so `A`/`B`/`C` are rejected. The fixtures now use valid lowercase UUIDs whose order matches `a`/`b`/`c`, and every assertion is kept. Production input is unaffected because MySQL always reports UUIDs. - `testParseVectorColumnTypeWithoutCapturingVectorNames` (NPE): correct, `CustomMySqlAntlrDdlParserListener` only handles ALTER. CREATE is now parsed through the base `MySqlAntlrDdlParser`, which still runs the VECTOR lexer. The ALTER schema-event test remains on the custom parser. Only Spotless ran locally. Compile and tests rely on the fork Build for e926b0bd64. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
