sharpca commented on issue #13079:
URL: https://github.com/apache/seatunnel/issues/13079#issuecomment-6570958293
Both asks are addressed in `cabfb80d`.
**1. One case per converter.** `JdbcTypeConverterLocaleTest` is now a
`@ParameterizedTest` over a `@MethodSource` of `(converter, source type,
expected type)` pairs — ten invocations, one per dialect, with the naming
pattern `"{0} maps {2}"`. The dialect name is also carried into the assertion
message, so a regression reads `DB2TypeConverter folded integer to the wrong
type under tr-TR` instead of an invocation index.
**2. Locale capture and restore.** The capture moved into `@BeforeEach`: the
base, `DISPLAY` and `FORMAT` defaults are read first, and only then is the
default switched to `tr-TR`. The restore moved into `@AfterEach`, which JUnit
runs even when the test body throws — so the guarantee is structural now rather
than a `finally` inside one combined test method.
`@ResourceLock("java.util.Locale")` is retained in case parallel execution is
enabled later.
Local evidence on JDK 17 (`-pl seatunnel-connectors-v2/connector-jdbc`,
current head): the targeted set is **68 tests, 0 failures, 1 skipped** (the
container-backed Oracle test), with the locale test itself reporting 10/0/0/0.
`spotless:check` passes.
**On the ping — I cannot send it yet.** CI still has not executed on this
head: the check-runs count is 0 and the workflow run for this PR stays
`action_required`, which means it is waiting for a maintainer to approve the
run. A fork contributor cannot trigger that gate. I will post the CI results
here the moment it executes.
To be explicit about what is and is not established: everything above, like
the earlier numbers, is local execution by me, not CI. The integration case
added in `704af8840` has not been compiled or run at all here (no Docker, and
the e2e module's SNAPSHOT prerequisites are absent from this machine), so it
depends entirely on that CI run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
