DanielLeens commented on issue #13079: URL: https://github.com/apache/seatunnel/issues/13079#issuecomment-6595078174
Hi @sharpca, thanks for addressing both test points so quickly. On the CI status: `action_required` here does not mean the run is waiting for a maintainer approval. For apache/seatunnel the build for a PR runs in the contributor's fork, and the `Build` check on the PR only reports the result of that fork run. The check on #13083 currently reports "Workflow run detection failed", and your fork `sharpca/seatunnel` has no workflow runs at all, so there is nothing for the check to pick up yet. There is no approval gate a maintainer can clear for this. The only `action_required` run on the apache side is `Label-when-reviewed`, a review-labeling workflow that does not build or test anything. To get CI running: 1. Open the **Actions** tab of your fork and enable GitHub Actions if it shows the enable button. 2. In the fork's Actions tab, select the **Build** workflow, click **Run workflow** and choose the PR branch (or push an empty commit to the branch). 3. The PR's `Build` check picks the fork run up automatically within about 15 minutes. The same steps apply to #13081. One small request for the review: the PR now touches more files than the thread lists (for example `Gbase8aTypeMapper`, `HiveTypeMapper`, `PrestoTypeMapper`, `PhoenixTypeConverter`, `SnowflakeTypeConverter`, the DuckDB/Redshift/Xugu/YashanDB catalogs, `DamengDataTypeConvertor`, `OceanBaseOracleCreateTableSqlBuilder`, and the new `JdbcMysqlSplitIT` case). Please list all of them in the PR description with the call site and the reason each one is locale sensitive, so the review can be checked against the full scope. The `JdbcDialect` / `CatalogUtils` and MySQL / OceanBase / SQL Server boundaries with #13063, #13076 and #13077 look clean on the main sources. Once the fork build has run, further review continues on #13083 itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
