SEZ9 commented on issue #13087: URL: https://github.com/apache/seatunnel/issues/13087#issuecomment-6593771299
@taowenjun Thanks for the detailed check-in on the `use_table_compression` scope. Answering your points directly: - Docs and tests: understood that the English/Chinese Hive sink docs already cover the default-off option, precedence, whitespace/case normalization, missing/blank-property fallback, unsupported-codec errors, and the inherited-ZSTD rejection, and that `HiveSinkConfigTest` plus `HiveIT#testExistingOrcTableCompression` passed in your fork CI at 511c69c0b (run 41378715037). I also note your caveat that the E2E matrices ran a JDK 11 engine container, so that run is not evidence for a JDK 17 engine runtime. Nothing more is needed from you on that point for this issue; please just keep the caveat visible in the PR description so reviewers do not read the run as JDK 17 coverage. - Scope behavior: agreed with the direction you describe: the option is ignored (not a job failure) for non-ORC tables and for tables that do not exist at sink initialization, including `orc.compress` set via `save_mode_create_template`, while explicit `compress_codec`, defaults, and normal validation still apply. That matches the intent of this issue, which is limited to inheriting `orc.compress` for existing ORC tables when `compress_codec` is unset. - Proposed wording: the paragraph you posted reads clearly and states both skip cases explicitly. Please go ahead and push it to #13085 (both English and Chinese) once your connectivity issue is resolved, and leave a comment there when it is up so it can be reviewed together with the behavior and tests already in the PR. Remaining asks: 1. Push the documentation clarification to #13085 and note it in the PR. 2. Keep #13085 focused on existing ORC tables as you suggested; the Parquet/other-format inheritance idea is welcome but should be tracked as a separate follow-up rather than expanding this issue. <!-- streview-comment:2235 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
