SEZ9 commented on issue #13087: URL: https://github.com/apache/seatunnel/issues/13087#issuecomment-6568637115
Thanks for the well-scoped proposal. The precedence (explicit `compress_codec` including `NONE` > the table's `orc.compress` property > existing default) and the default-off `use_table_compression` option look reasonable for backward compatibility. A couple of things to cover in #13085: please include documentation for the new option and unit tests for the trimming/case-insensitive normalization and the unsupported-codec error path. Since inherited ZSTD is explicitly rejected on current dev until the separate ORC/ZSTD fix lands, it would also help to note that in the docs so the behavior change after that fix is clear. One question: for non-ORC file formats and automatically created tables, which you mention are out of scope, is `use_table_compression` simply ignored, or does the job fail? Stating this explicitly in the docs would help users. <!-- streview-comment:2225 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
