zhangshenghang commented on PR #12459: URL: https://github.com/apache/seatunnel/pull/12459#issuecomment-6594215303
Thanks — and no need to apologize, both corrections are fair. Addressed in 3290e4c96: - Issue 1: the heap check is now split by JDK version — JDK 9+ uses `jcmd <pid> GC.heap_info`, JDK 8 uses `jmap -heap <pid>` (removed in JDK 9+) — and the sample stays labeled as `jmap -heap` output from JDK 8 (EN/ZH). - Issue 2: the hybrid page restores `seatunnel-engine-server.log` for the default master-and-worker deployment (EN/ZH); the tuning-guide and log-analysis greps now use the `seatunnel-engine-*.log` glob with a comment mapping the roles to `-server.log` vs `-master.log`/`-worker.log` (EN/ZH, including the PR-description hybrid bullet). - Issue 3: the EN IMap storage sizing block now mirrors the ZH one (local-file note + `hadoop fs -du -s -h` line). - Issue 4: the ZH checkpoint-storage YAML comment `//` is fixed to `#`. - Issue 5: the PR description is rewritten to match the current 43-file diff only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
