DanielLeens commented on PR #11597: URL: https://github.com/apache/seatunnel/pull/11597#issuecomment-6594223121
@SEZ9 the comment-only follow-up I mentioned is pushed as `e3a5965c54d`. No logic changed; the diff only adds comments. - `RunningJobSlotUsageBuilder`: added comments to the four-argument `build` overload, `aggregateSlotUsage`, `aggregatePipelineSlots`, `belongsToRunningJob`, `containsOwnedSlots`, `buildAssignedSlotSet`, `isAssignedToJob` and the `SlotKey` fields. They cover three rules: an owned slot is counted only if the resource manager's assigned-slot snapshot still has the same allocation; `slotSourceAvailable` is false when the resource manager is uninitialized, or when it reports no assigned slots while running jobs still hold owned slots; and `SlotKey` includes the owner job and allocation sequence because `SlotProfile#equals` ignores the owner and slot ids get reused. - CI: fork Build run 41568689622 for this head is queued. I am not claiming a pass until it completes. - The smaller nonblocking test controls from my review are still not added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
