goutamadwant opened a new pull request, #13110:
URL: https://github.com/apache/seatunnel/pull/13110
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code
changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB
issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the
pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix
typo in README.md doc`.
-->
### Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull
request adds checkstyle plugin.-->
I'm happy to contribute this fix to SeaTunnel.
Fixes #13106. This is a separate Flink commit-recovery prerequisite for
#12983.
Route restored committables through restoreCommit and preserve that
provenance across aggregation, retries and partial progress. Fresh commits
retain strict failure handling; pending work is no longer acknowledged as
successful. Preserve existing operator identities and legacy serializer
compatibility.
#12807 already handles API-level multi-table forwarding. The broader schema
protocol remains in #11958/#11960; collector restoration remains in #12983.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released SeaTunnel versions or within the unreleased branches such as dev.
If no, write 'No'.
If you are adding/modifying connector documents, please follow our new
specifications: https://github.com/apache/seatunnel/issues/4544.
-->
Checkpoint/savepoint recovery reconciles restored transactions instead of
treating them as fresh commits or dropping pending retries. No new
configuration option.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If you are adding E2E test cases, maybe refer to
https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf,
here is a good example.
-->
- Reproduced ordinary-commit routing of legacy restored work on dev
(`3244c9504c75`) before this patch.
- Passed 24 focused tests on this standalone branch:
RecoveryCommitSerializerTest, RecoveryTopologyTest,
RestoredCommittableOperatorTest, CheckpointCommitWrapperSerializerTest,
FlinkSimpleAggregatedCommitterTest, FlinkGlobalCommitterTest and adjacent
FlinkSinkWriterTest. Packaged Flink 1.13/1.15/1.20 starters and their
dependencies.
- Formatting passed. Full Java 11 repository verify passed with tests
skipped on the combined JDBC + Flink tree; its changed files match the two
standalone patches byte for byte. The focused tests above ran separately.
```sh
./mvnw -Pci -Dmaven.jar.forceCreation=true -pl
seatunnel-core/seatunnel-flink-starter/seatunnel-flink-13-starter,seatunnel-core/seatunnel-flink-starter/seatunnel-flink-15-starter,seatunnel-core/seatunnel-flink-starter/seatunnel-flink-20-starter
-am
-Dtest=RecoveryCommitSerializerTest,RecoveryTopologyTest,RestoredCommittableOperatorTest,CheckpointCommitWrapperSerializerTest,FlinkSimpleAggregatedCommitterTest,FlinkGlobalCommitterTest,FlinkSinkWriterTest
-Dsurefire.failIfNoSpecifiedTests=false verify
```
The earlier collector/JDBC/Flink prerequisite composition passed nine native
cases across Flink 1.13/1.15/1.18/1.20 ([restore fixture at the prerequisite
commit](https://github.com/goutamadwant/seatunnel/blob/0df6a72070699eaa6cacfbfa77ea9363e8999271/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/cdc/mysql/MysqlCDCWithFlinkSchemaChangeIT.java)).
That is historical combined-tree evidence, not a native matrix for this
standalone branch. Hosted CI is separate.
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License
Notice according
[New License
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
* [ ] If necessary, please update the documentation to describe the new
feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If necessary, please update `incompatible-changes.md` to describe the
incompatibility caused by this PR.
* [ ] If you are contributing the connector code, please check that the
following files are updated:
1. Update
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
and add new connector information in it
2. Update the pom file of
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
3. Add ci label in
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
4. Add e2e testcase in
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
5. Update connector
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
No new connector or binary package is added. Existing registration files
still apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
