1328837476-hug commented on code in PR #12907: URL: https://github.com/apache/seatunnel/pull/12907#discussion_r4469799185
########## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-7/README-ingres.md: ########## @@ -0,0 +1,68 @@ +<!-- +Licensed to the Apache Software Foundation (ASF) under one or more Review Comment: Removed README-ingres.md in 37b5dbdc1 and moved the setup requirements, environment variables, run command and cleanup notes into the JdbcIngresIT class comment. Both source docs now point to the test. The 68-module reactor verify and all 33 focused tests pass. Thanks for the suggestion! ########## docs/zh/connectors/sink/Jdbc.md: ########## @@ -272,6 +272,15 @@ Postgres 9.5及以下版本，请设置为 `postgresLow` 来支持 CDC | IRIS | Inceptor | Highgo | | DSQL | | | | YashanDB | | | +| Ingres | | | + +#### Ingres Review Comment: This dialect reuses GenericTypeMapper/GenericTypeConverter, so conversion depends on the JDBC type code reported by the driver. In 37b5dbdc1 I added the mapping table to both source docs and linked it from both sink docs. For example, JDBC INTEGER maps to INT, VARCHAR to STRING, and DECIMAL(10,2) to DECIMAL(10,2). The table also explains precision fallbacks and unsupported types. Native INGRESDATE, MONEY and intervals have no dedicated mapping; actual driver metadata still needs real-server validation. This documents source conversion, not a verified reverse mapping or Ingres sink support. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
