zhangshenghang commented on PR #12986: URL: https://github.com/apache/seatunnel/pull/12986#issuecomment-6683334323
Issue 2 is now fixed too (da2d164b4): the dialect paragraphs in EN/ZH source and sink now use the clearer "omitted vs. invalid explicit dialect" wording — set values must match a `dialectFactoryName()` and take priority over the URL; unset values fall back to URL matching; an unmatched explicit value fails instead of falling back. To eliminate the double-edit you flagged, the wording, the option-table rows and the fallback paragraph are byte-identical to sibling #13149, so whichever PR merges second auto-resolves those hunks. Also from your overlap note: the NATIVE headers sentence in #13149 is now corrected in both languages (e675a7c15) — headers are carried separately in the Kafka record headers, not written into the `value` byte array — and is byte-identical to this PR's corrected sentence. The four JDBC dialect-list tables were already byte-identical across the two PRs. Remaining known textual overlap: #13149's Kafka `semantics` blockquote keeps its own wording because the `#semantics` anchor your sentence links to does not exist on that branch; that single line may need a one-line pick on whichever PR merges second. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
