zhangshenghang commented on PR #12986: URL: https://github.com/apache/seatunnel/pull/12986#issuecomment-6699976283
Thanks for the approval and for catching the leftover paragraph — that was residue from folding Issue 2's wording over from #13149. Fixed in d7c081ea6: the old `GenericDialect` fallback paragraph is deleted on all four JDBC pages (EN/ZH source and sink); the new paragraph above now fully replaces it. On Issue 5 (table padding): deliberately left as-is for now. The `IRIS`/`DuckDB` rows are byte-identical between this PR and sibling #13149 so the second merge auto-resolves; re-padding them here would break that identity and cost a manual one-line pick for a cosmetic gain. Happy to apply the tidy-up to both PRs in a follow-up after one of them merges. Both PRs remain ready to merge; the only known overlap left is the Kafka `semantics` blockquote wording noted in the #13149 review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
