SEZ9 commented on PR #12858:
URL: https://github.com/apache/seatunnel/pull/12858#issuecomment-6841697815

   Thanks @karthik-0306 for the ping.
   
   A quick clarification on my side: approving the pending workflow runs and 
reconciling the required check are actions for a write-capable maintainer, not 
something I can do, so that part of your request is best left with them.
   
   On the review side, I can only consider the earlier eight points resolved 
based on what is actually in the diff at `5e82f43`, not on the discussion in 
this thread. To make that pass quick, could you point me at where each of the 
following landed at this head (a short pointer per item, or "intentionally 
unchanged" where that applies, is enough; no new commit needed for this):
   
   - F1: relative `seatunnel_home` no longer double-resolves the script path 
when combined with `cwd`.
   - F2: `select_plugins` handles connector lines with stray whitespace or 
trailing comments rather than leaving them enabled.
   - F3: inter-process locking around snapshot → select → run → restore, 
including release on the failure path.
   - F4: behaviour on Windows (`bin/install-plugin.cmd` vs. a stray `bash.exe` 
on PATH).
   - F5: `version` is validated before `plugin_config` is rewritten, rejecting 
values that `install-plugin.sh` refuses or that switch it into Maven mode.
   - F6: non-UTF-8 `plugin_config` and `connectors=None` surface as 
`PluginInstallError` rather than raw `UnicodeDecodeError`/`TypeError`.
   - F7: rollback only writes `original` when `select_plugins` actually changed 
the file.
   - F8: the error-message example version no longer points at `'3.0.1'`.
   
   I will verify each against the head diff and follow up with anything still 
open.
   
   <!-- streview-comment:2304 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to