SEZ9 commented on issue #10443:
URL: https://github.com/apache/seatunnel/issues/10443#issuecomment-6870070608

   @yidaimi Thanks for running the source-side matrix and for the detailed 
write-up. S01–S08 cover exactly the behaviors we cared about on the read path 
(per-job CA trust via `tls_ca_file`, hostname verification with an explicit 
opt-out, and the `retryWrites` rejection), and I agree nothing in that table 
calls for a change to `connector-amazondocumentdb`. Noting stream mode, 
parallel splits and large collections as not covered is fine for V1.
   
   Your clarification about #12907 also sounds right to me; I don't see 
anything in it that depends on this run.
   
   On the split from the earlier discussion:
   
   - #13198 / #13200: keeping `retry.max` / `retry.interval` together with the 
`buffer-flush.*` defaults is fine since it is the same root cause in 
`MongodbSinkFactory`; no need to split further. Glad the 
`incompatible-changes.md` entry is in.
   - #13199 / #13215: please confirm in #13215 that the single shared 
client-settings builder is used by the writer, the catalog (save mode) and the 
dry-run validator, and that the TLS test server covers both the trusted-CA 
success and untrusted-CA failure cases, as laid out in #13199.
   
   Nothing else is outstanding from this issue; let's continue the remaining 
review in the two PRs, and I'll keep this issue open until both are merged.
   
   <!-- streview-comment:2327 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to