DanielLeens commented on issue #10443:
URL: https://github.com/apache/seatunnel/issues/10443#issuecomment-6739656187

   Thanks for the concrete DocumentDB matrix. Current `dev` confirms two 
independent MongoDB-sink problems:
   
   1. `MongodbSinkOptions` declares defaults of 1000 rows and 30000 ms, but 
`MongodbSinkFactory` only calls the builder setters when `getOptional(...)` is 
present. An omitted option therefore leaves the builder values unset rather 
than applying the declared defaults.
   2. The write provider constructs the client from the URI, and the dry-run 
validator constructs its own client settings. There is no sink option that 
builds a per-job CA trust context, so a JVM-wide trust store is presently the 
only visible route for an RDS CA not already trusted by the JDK.
   
   The direction is useful, but please split it before implementation:
   
   - Open one focused connector issue/PR for an optional per-job CA-file 
setting. It must use one shared settings builder for both dry-run validation 
and the writer, retain hostname validation, avoid trust-all and JVM-global 
trust-store changes, and include a TLS test server proving that the configured 
CA succeeds while an untrusted CA fails.
   - Open a separate bug issue/PR for the omitted flush defaults. Its 
regression must create the sink without either option and verify that the 
writer receives 1000 / 30000, plus retain an explicit-option control.
   
   Please do not combine these behaviorally unrelated fixes, and do not rely on 
the DocumentDB result alone as proof of generic MongoDB compatibility. Once the 
two tracker links are posted here, either focused PR can be reviewed on its own 
merits.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to