SEZ9 commented on issue #12809: URL: https://github.com/apache/seatunnel/issues/12809#issuecomment-6870301452
Hi @lukangyu, thanks for the FieldRename claim and for doing the pre-check against `FieldRenameConfig`, `FieldRenameTransformFactory#optionRule()`, `FieldRenameTransform` and the E2E configs (`field_rename_regex_default.conf`, `table_field_rename_multi_table.conf`). Nobody else in this thread has claimed FieldRename, so please go ahead. A few concrete asks for the PR: - Open it as a single documentation-only PR against `dev` covering both `docs/en/transforms/field-rename.md` and `docs/zh/transforms/field-rename.md`, and link it back to #12809 so the claim is recorded here. - Keep the EN and ZH pages in sync and make sure every documented option (name, type, required/optional, default) matches what `FieldRenameTransformFactory#optionRule()` currently enforces on `dev`. - Since you referenced the regex-default and multi-table E2E configs, please make sure the runtime behaviour those configs exercise is actually explained on the page and that the examples you include are runnable. - If you hit any code/doc mismatch while verifying, please raise it as a separate issue rather than folding a code change into the doc PR. Once the PR is up, drop the link here and we will take the substantive review there. <!-- streview-comment:2332 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
