SEZ9 commented on PR #11557:
URL: https://github.com/apache/seatunnel/pull/11557#issuecomment-6870767669

   @davidzollo thanks for the update on 
`1f0ac9d495323a036a27bcca5320b547a9f9b0a0`.
   
   Scoping this reply to the one previously flagged finding, F1 (HIGH, 
Security): the unsafe Java deserialization pattern in 
`seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/task/operation/source/ManagedSourceRegisterOperation.java`.
   
   From the thread, the fix for F1 landed in `5a0f93b3` and is unchanged on the 
current head `1f0ac9d4`, but the finding is still open for two reasons: the 
original reporter has not confirmed the fix, and the per-issue row for F1 is 
still missing from the PR description.
   
   To close F1, I'd ask for the following on the next push / description edit:
   
   1. Add the F1 row to the PR description: a short statement of what 
`ManagedSourceRegisterOperation` deserializes, what `5a0f93b3` changed (e.g. 
what is now validated or restricted before the payload is read), and why the 
remaining path is safe.
   2. Point to the test (class and method name) that exercises the hardened 
deserialization path, or say explicitly if none exists yet so we can decide 
whether one is required before merge.
   3. Ping the original reporter on the thread once the row is in place so they 
can confirm or push back.
   
   Once those are there I can re-verify F1 against the current head. Everything 
else stays with the previously recorded status.
   
   <!-- streview-comment:2338 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to