SEZ9 commented on issue #13273: URL: https://github.com/apache/seatunnel/issues/13273#issuecomment-6870907536
Thanks for the detailed analysis. Since you have marked that you are willing to submit a PR, a focused fix to `decodeJobBasicInfo` would be welcome. A few suggestions for the change: - Rather than relying only on skipping a single header byte with `in.readByte()`, please make sure the fast path matches the actual layout produced by `SerializationService.toData(JobImmutableInformation)`, and add a unit test that asserts the fast-path `jobName` and `createTime` equal the values from normal `toObject(...)` deserialization. That way the fast path is actually exercised instead of always falling through to the `catch (Throwable)` fallback. - Include a regression case with a `JobImmutableInformation` larger than 16 MB so the current false-success path is covered, and assert that `/running-jobs/summary` returns the real, bounded name and timestamp. - As a defensive measure, validate the decoded values in the fast path (for example an implausible string length or `createTime`) and fall back to full deserialization on anomalies, so a future layout change cannot silently produce garbage output again. <!-- streview-comment:2340 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
