SEZ9 commented on issue #13273:
URL: https://github.com/apache/seatunnel/issues/13273#issuecomment-6906096552

   Thanks @alexey-bass for opening the PR and for noting that it also validates 
the decoded values. Review feedback on the four points from the previous 
comment (fast-path parity with normal `toObject(...)` for `jobName` and 
`createTime`, the regression for the former false-success path, retained 
fallback coverage in `JobInfoServiceNullSafetyTest`, and the before/after 
summary size in the description) is best raised on the PR itself once the diff 
has been looked at, so there is no need to re-confirm them here. As noted 
earlier, please keep the change scoped to the summary decoder, with no changes 
to the full `/running-jobs` response, job state, or the persisted 
`JobImmutableInformation` format.
   
   Noted on the pending workflow approval for first-time contributors.
   
   <!-- streview-comment:2380 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to