SEZ9 commented on PR #11856:
URL: https://github.com/apache/seatunnel/pull/11856#issuecomment-6889026742

   Thanks for the follow-up on `1f003592570833eb48b2a7edad0830e960e1c462`. 
Fixing the regression test from `b32e5360d88` to import the concrete type 
returned by `MembershipServiceEvent#getMember()` looks like the right 
correction, and keeping the mock and assertions unchanged is fine.
   
   One note: this head only touches the test import, so none of the points from 
the earlier review are addressed yet. Still open:
   
   1. **Marker publish timing (HIGH)** – the graceful-shutdown marker is 
written from `ManagedService.shutdown()`, when the Hazelcast node is already 
PASSIVE and IMap writes can be rejected. Please move the publish to a point 
where the member is still ACTIVE (or show evidence that the write succeeds in a 
real graceful shutdown), otherwise the WARN downgrade can silently no-op.
   2. **Marker lifecycle in `CoordinatorService`** – the marker is 
destructively consumed before task-failure processing, so a master failover 
mid-processing loses the classification. Please consume after processing (or 
make the read non-destructive) and give the entries a real expiry.
   3. **Error payload on the graceful path** – replacing the `JobException` in 
`TaskExecutionState` with a plain `String` changes what reaches job history / 
REST error fields and contradicts the "state handling unchanged" guarantee. 
Please keep the throwable and only adjust the log level.
   4. **`engine_gracefulMemberRemoval` eviction** – no TTL/eviction configured 
and the manual TTL check relies on cross-node clocks. Please configure 
map-level TTL or max-idle instead.
   5. **Classification by message matching in `PhysicalVertex`** – deciding 
ERROR vs WARN by regex over free-text lets any failure that mimics the offline 
template be downgraded. Please carry an explicit flag/typed cause rather than 
matching text.
   6. **Duplicate template** – the offline message is a format string in 
`CoordinatorService` and a regex in `PhysicalVertex`; please share a single 
constant (or, better, drop the regex per point 5).
   7. **Docs** – please add a short section under `docs/` describing the 
graceful-shutdown marker map and the WARN downgrade behavior.
   
   Also, since no local compile or runtime validation was run on this head, 
please let the GitHub CI run complete and share the unit and engine integration 
results here before we call the test fix verified.
   
   <!-- streview-comment:2364 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to