SEZ9 commented on PR #12269:
URL: https://github.com/apache/seatunnel/pull/12269#issuecomment-6905386566

   @Dev-next-gen thanks for the follow-up. From your description, b76ec3a51 
should cover the open points from the earlier round: the 
`toUpperCase(Locale.ROOT)` change in `ConnectorCheckCommandArgs` and 
`MetadataExportCommandArgs`, the `Locale.ROOT` arguments on the remaining 
`toLowerCase()` calls in `getPluginMappingPrefix`/`findPluginJarPath`, and the 
discovery test now resolving the `Jdbc` sink so the fixed line is exercised 
through `selectPluginJar`/`findMatchingUrl`. The before/after run you pasted is 
helpful context, but I'd like to confirm against the actual diff before marking 
those items resolved, so I'll go through the changed files in b76ec3a51 rather 
than rely on the summary.
   
   One minor leftover: the sink-resolution test still lives in 
`SeaTunnelSourcePluginDiscoveryTest` while asserting sink behaviour. I'm fine 
keeping it there if moving it would only duplicate fixture setup — a short 
comment on the test explaining why is enough. Your call.
   
   Once CI has run on b76ec3a51 I'll do a final pass. Thanks again for the 
thorough trace.
   
   <!-- streview-comment:2374 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to