Dev-next-gen commented on PR #12269:
URL: https://github.com/apache/seatunnel/pull/12269#issuecomment-6964677302

   @SEZ9 You were right in your first review: the lock does nothing in either 
module. Nothing in the repository turns on JUnit parallel execution. Grepping 
`junit.jupiter.execution` across every `pom.xml` and 
`junit-platform.properties` only finds `parallel.mode.default = same_thread` in 
five e2e resource files and never `parallel.enabled = true`, so Jupiter runs 
the tests in `seatunnel-plugin-discovery` and `seatunnel-starter` one at a 
time. On the keys: both new tests use `default-locale`, the same key as 
`JobStatusTest`. The `java.util.Locale` key belongs to the DuckDB tests in 
`connector-jdbc`, and those run in that module's own surefire JVM (no pom 
overrides `forkCount` or `reuseForks`), so they can't share a default locale 
with these tests either way. I kept the annotations so the guard is already 
there if parallel execution is turned on later. On `toLowerCase()`: yes, 
b76ec3a51 changed all five, and every case conversion left in 
`AbstractPluginDiscovery.java` now passes `Local
 e.ROOT` (lines 430-432, 459-460 and 470).
   
   @DanielLeens I applied Issue 1 in 8cef2c678. Both Turkish-locale tests now 
save `Locale.getDefault(Locale.Category.DISPLAY)` and 
`Locale.getDefault(Locale.Category.FORMAT)` before switching to tr-TR, and 
restore them after the global default in `finally`. On JDK 17, `spotless:check` 
passes on both modules and both classes pass 
(`SeaTunnelSourcePluginDiscoveryTest`: 6 tests, 
`ConnectorCheckCommandArgsTest`: 2 tests, 0 failures, 0 errors). The fork has 
no Build run for 528f5e3a1 or 8cef2c678 (the Actions API returns 0 runs for 
both SHAs), so I can't link an exact-head CI run yet.
   
   Found by a defect-hunting pipeline I build and run 
([Dev-next-gen](https://github.com/Dev-next-gen)), using Claude Code with 
Anthropic's Claude Opus 5.5.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to