fatmanverse commented on PR #12802: URL: https://github.com/apache/seatunnel/pull/12802#issuecomment-6908730865
@SEZ9, the review checklist has been reconciled against commit `8a2b4525a46657554da4bd90e8e93c15845f724e`: 1. **Bounds:** the sink computes the prospective plain-text length before formatting and uses scientific notation above Excel's cell limit. The read side intentionally follows other text-based file readers and does not add a format-specific rejection; this is now explicit in the PR description and EN/ZH source docs. The scale/extreme-exponent test now runs against POI and EasyExcel and includes 1E-2147483647 as well as the large positive exponents. 2. **EasyExcel .xls:** ExcelReadStrategyTest.testXlsReadKeepsNumericPrecision reads a real .xls workbook with both engines and asserts DOUBLE, DECIMAL and cached formula results. Both parameterizations passed in the remote run. 3. **Connector docs:** source and sink LocalFile.md exist in EN/ZH and describe the numeric reading rules, mixed cell types, and conversion alternatives. The follow-up corrects FLOAT precision wording and explains formula cache differences and scientific text. 4. **Uniform numeric output:** no new permanent option is added. CAST(col AS DOUBLE) keeps numeric cells while accepting rounding; CAST(col AS STRING) keeps text cells. 5. **Declared scale:** lossless padding is applied only within declared precision. Exact BigDecimal assertions cover padding, zero, extra fractional digits, oversized integer values and extreme exponents on both engines. 6. **Upgrade wording:** the notes describe stored double text and the integer threshold rather than promising arbitrary Excel precision. FLOAT now explicitly converts to 32-bit float. 7. **Non-BigDecimal input:** ExcelGenerator uses the existing BigDecimal directly or parses value.toString(); the hard cast is not required for other inputs. 8. **Test comment:** the precision fixture is described as a POI text cell, not as sink output. Remote JDK 17 validation passed all 38 Excel tests (32 reader + 6 writer), with no failures, errors or skips. Spotless passed. All 334 modules passed backend verify with UI skipped before the final locale-only test assertion adjustment. After that adjustment all 38 tests passed again under German JVM locale (de_DE). GitHub Build remains a separate pending gate; this reply does not claim it has passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
