SEZ9 commented on PR #12802:
URL: https://github.com/apache/seatunnel/pull/12802#issuecomment-6935940462

   @fatmanverse thanks for the point-by-point reconciliation against 
`8a2b4525a46657554da4bd90e8e93c15845f724e`.
   
   Your comment explains the intent behind each of the eight points, but I 
can't mark any of them resolved from the description alone. They all stay open 
until I have checked each one against the diff at that commit.
   
   Two questions in the meantime:
   
   1. **Bounds (1):** you say the read side intentionally adds no 
format-specific rejection. The original concern was that a text cell such as 
`1E+2147483647` becomes a DECIMAL that is later expanded to plain form. Which 
part of the change guarantees that a value like `1E+2147483647` or 
`1E-2147483647` is never expanded, both in the declared-scale padding from 
point 5 and on the sink path?
   2. **Build:** you report that Build run 43817420706 on this commit finished 
with a failure, but the CI section of your comment is cut off. Which job 
failed, and is it related to this change?
   
   <!-- streview-comment:2386 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to