sudeephazra commented on PR #12293:
URL: https://github.com/apache/seatunnel/pull/12293#issuecomment-6909503163

   @SEZ9 Please see the comments for 6d9188efe9ba6161787cc3d5231a0cf31184927a
   
   Both items are already addressed in the current checkout.
   - PR12293-F6: account_key is in the shared log-mask list at 
[ConfigShadeUtils.java (line 
65)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/tree/ADLS_MergeConflict/seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/utils/ConfigShadeUtils.java:65).
 It applies to parsed-configuration logging across connectors using that option 
name. The requested mention already exists in the PR description (in the 
UPDATs), and the global effect is documented in the [English configuration 
guide:25 (line 
25)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/tree/ADLS_MergeConflict/docs/en/introduction/configuration/config-encryption-decryption.md:25)
 and [Chinese guide:24 (line 
24)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/tree/ADLS_MergeConflict/docs/zh/introduction/configuration/config-encryption-decryption.md:24).
 These correctly distinguish log masking from encryption.
   - PR12293-F2: The wording is present under “Transactional commit 
prerequisite” in the [English sink doc:39 (line 
39)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/tree/ADLS_MergeConflict/docs/en/connectors/sink/ADLSFile.md:39).
 Lines 41–44 require HNS, explain partial-output risk without it, and require 
tmp_path and path to share a container. The equivalent wording is in the 
[Chinese sink doc:31 (line 
31)](https://github.com/sudeephazra/seatunnel-adls-connector-v2/tree/ADLS_MergeConflict/docs/zh/connectors/sink/ADLSFile.md:31).
 The documentation item can be ticked off.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to