SEZ9 commented on PR #12293:
URL: https://github.com/apache/seatunnel/pull/12293#issuecomment-6936073357

   @sudeephazra thanks for the update. Your comment appears cut off partway 
through the PR12293-F4 entry, so I can only respond to F1 and the start of F4.
   
   **PR12293-F1:** Thanks for the description: trimmed account, container, 
endpoint and authentication values via the validator's `required()` helper, 
advanced-property keys and values trimmed before they enter the Hadoop 
configuration, and whitespace regression cases for Shared Key and OAuth. That 
matches what the finding asked for, but I'll keep F1 open until I've verified 
the changes in `ADLSHadoopConf.java` and `ADLSHadoopConfTest.java` against the 
PR diff.
   
   **PR12293-F4:** The text stops after "Minimum requirement addressed" and a 
truncated link to `ADLSRuntimeCompatibility.java` (line 132), so I can't tell 
what changed. Could you repost the rest and confirm:
   - Is a non-HTTPS `authority_host` now rejected before the `client_secret` is 
sent?
   - How are `authority_host` and `tenant_id` validated so the token endpoint 
can't resolve to an arbitrary URL?
   - What does "minimum requirement" leave out, and do you plan to cover it in 
this PR or later?
   
   **PR12293-F2, F3, F5, F6, F7, F8:** No status for these came through. Please 
post a short note for each saying whether it is addressed and where, or not yet.
   
   <!-- streview-comment:2388 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to