Dev-next-gen opened a new issue, #13290:
URL: https://github.com/apache/seatunnel/issues/13290

   ### Search before asking
   
   - [x] I had searched in the 
[feature](https://github.com/apache/seatunnel/issues?q=is%3Aissue+label%3A%22Feature%22)
 and found no similar feature requirement.
   
   ### Description
   
   `CreateTableParser` exists as three copies that have to be patched in 
lockstep:
   
   - `connector-common/.../common/util/CreateTableParser.java`, used through 
`CatalogUtil` by Doris and ClickHouse
   - `connector-maxcompute/.../maxcompute/util/CreateTableParser.java`, 
imported by `MaxComputeCatalogUtil` (line 30)
   - `connector-clickhouse/.../clickhouse/util/CreateTableParser.java`, which 
nothing in `connector-clickhouse` references outside its own file
   
   `connector-maxcompute/pom.xml` already depends on `connector-common` (line 
51), so `MaxComputeCatalogUtil` can import the `connector-common` parser, and 
the MaxCompute and ClickHouse copies, along with the MaxCompute copy of 
`CreateTableParserTest`, can be removed.
   
   ### Usage Scenario
   
   Any later fix to the template scanner lands once instead of three times. 
#12327 had to apply the same quote-handling change to all three copies.
   
   ### Related issues
   
   #12327
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to