CryoThrust commented on issue #13290:
URL: https://github.com/apache/seatunnel/issues/13290#issuecomment-6936192744

   Yes, I can take the parser deduplication for Apache SeaTunnel. On current 
`dev` (`37309e1a8`), the common and MaxCompute implementations are identical 
apart from their package, MaxCompute already depends on connector-common, and 
the ClickHouse-local parser has no connector callers.
   
   I'll route MaxCompute through the common parser and keep only one scanner 
implementation. Because the two local classes (including `ColumnInfo`) are 
public in published connector jars, I propose retaining their existing names as 
small deprecated forwarding adapters rather than deleting those binary entry 
points immediately. This still makes future parser fixes land in one 
implementation, without forcing callers to migrate in the same release. If 
those classes are explicitly outside the compatibility contract, we can discuss 
removing the adapters separately.
   
   This will not duplicate the quote-handling fix in #12327 or change parsing 
behavior. I will cover adapter results/offsets and run the existing common, 
MaxCompute and ClickHouse tests plus packaging/format checks. The 
`CreateTableParserTest` copies mentioned here are not on current `dev`; any 
test movement from #12327 should stay with that author until its patch lands.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to