CryoThrust opened a new pull request, #13291:
URL: https://github.com/apache/seatunnel/pull/13291

   Apache SeaTunnel currently maintains the same create-table template scanner 
in connector-common, MaxCompute and ClickHouse. MaxCompute uses its local copy 
while the ClickHouse-local copy has no connector callers. This contribution 
routes MaxCompute through connector-common and removes the two duplicate 
scanner implementations, so future parsing fixes have one implementation to 
maintain.
   
   The old public parser classes remain as deprecated forwarding adapters. 
Their nested `ColumnInfo` types, constructors, getters and mutable map results 
are preserved; removing those classes outright would break callers compiled 
against the published connector jars. Both connectors already depend on 
connector-common, so no dependency or configuration change is needed. The 
common scanner is unchanged, and this PR does not implement or copy the 
quote-handling change in #12327.
   
   Related to #13290. The proposal to retain compatibility adapters is recorded 
in the issue; feedback on their eventual removal is welcome.
   
   Validation on JDK 11:
   
   ```sh
   mvn -B -T1C \
     -pl 
seatunnel-connectors-v2/connector-common,seatunnel-connectors-v2/connector-maxcompute,seatunnel-connectors-v2/connector-clickhouse
 \
     -am -DskipTests spotless:apply install
   mvn -B -T1C \
     -pl 
seatunnel-connectors-v2/connector-common,seatunnel-connectors-v2/connector-maxcompute,seatunnel-connectors-v2/connector-clickhouse,seatunnel-connectors-v2/connector-doris
 test
   mvn -B -pl seatunnel-e2e/seatunnel-connector-v2-e2e/connector-maxcompute-e2e 
\
     -DskipUT=true -DskipIT=false \
     '-Dit.test=MaxComputeIT#testCreateTemplateWithInferredAndExplicitColumns' 
verify
   ```
   
   The four unit-test modules pass 341 tests with no failures/errors/skips. The 
new compatibility cases check decimal types, quoted-name offsets, nested 
constructors and map mutability. An additional external client compiled against 
the old implementations runs unchanged against the new packaged jars, and 
`javap -public -s` reports identical public signatures for both legacy parsers 
and their nested result classes. Scoped dependency packaging, formatting and 
Checkstyle pass.
   
   The new emulator-backed IT compiles, but its local run is still downloading 
`maxcompute/maxcompute-emulator:v0.0.7` before fixture startup. It has not 
executed the create/insert/readback assertions and is not counted as a pass. 
Keeping this draft until that validation completes; no live MaxCompute service 
or full engine-job coverage is claimed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to