SEZ9 commented on PR #12984:
URL: https://github.com/apache/seatunnel/pull/12984#issuecomment-6992109592
Status on `fd0c32bc64ea4eeacd736767d0176f41c9377345`: the fork Build
42347729501 has completed with FAILURE and the Apache Build still reports
failure, with no retry outstanding. The PR is not mergeable yet, and the
self-reviews on this thread do not replace an independent maintainer review.
Remaining asks before that review can proceed:
1. **Diagnose the completed attempt per job.** On attempt 2 there were three
distinct failures:
- **Amazon SQS:** LocalStack could not start (`/testcontainers_start.sh:
Text file busy`), so the job failed before any assertion.
- **Kafka:** a committed-offset assertion failed.
- **Engine:** the job observed FAILED instead of CANCELED.
Please post what the final attempt shows for each of these, including the
failing test name and the relevant log excerpt. The SQS failure looks like a
fixture startup problem, but the Kafka and engine failures are real assertion
results and need a root cause, not just another retry.
2. **Rule the new commit in or out.** `fd0c32bc` brings in
`SourceCheckpointLockHandoff.java`, changes to `SourceFlowLifeCycle.java`, and
changes to `BackpressureSlowSinkIT.java`. Please state explicitly whether the
Kafka offset and engine FAILED/CANCELED failures touch that code path, and
whether the same tests fail on current `dev` without this PR.
3. **Resolve the scope question.** The connector-jar timer fix is reported
unchanged since `e9279e87`, but the PR now also carries four files (+839/-44)
from an already-merged upstream change. Please confirm what the effective diff
against `dev` contains and why those files need to be part of this PR.
4. **Keep further changes targeted.** Please don't add unrelated dependency
changes or blind re-runs; choose any further retry only after the diagnosis in
point 1.
Once the three failures are explained and the scope is confirmed, I'm happy
to take another look at the timer `close()` teardown itself.
<!-- streview-comment:2435 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]