SEZ9 commented on PR #12626: URL: https://github.com/apache/seatunnel/pull/12626#issuecomment-6994117491
Thanks for sticking with this one. Here is where things stand on head `5204dd2da73e971719212e963791f2fd2fbb7b67`, which is unchanged. **CI (Build run 43864690443)** - The run finished with a failure, but both engine-v2 lanes and the Linux and Windows unit suites passed. - The Kafka JDK 11 and connector part 2 JDK 17 runs failed on Maven Wrapper download rate limits. Please retry them once the download service recovers. - Connector part 5 JDK 11 is also red and its cause is not confirmed yet. Please keep that job log and post the failing step or stack trace here, so we can tell whether it is related to this change. **Still open from the previous review** - **Shared-comparator race:** the `WritableComparator` registry is iterated and mutated without the lock Hadoop's writers use. The `getConf`/`setConf` pair is also a read-compare-write that can null out a running job's `Configuration`. Please either take the same lock or explain why the unsynchronized access is safe here. - **Phased Metaspace validation:** this is still outstanding. Could you share the results once you have them, including how the phases were run and what was measured? Since the head has not changed, could you also say how you plan to handle the other points from the previous review? - The forced initialization of `PowerOfTwoBufferPool` during Mongo cleanup. - `clean()` not being fully best-effort for non-`LinkageError` errors. - Verifying the reflective contract against the real driver and Hadoop jars. - A maintainer pointer for the hard-coded MongoDB/Hadoop internals. - De-duplicating the WARN on layout drift and adding an off switch. - The `entrie(s)` log wording. A short note per item saying "fixed in this PR" or "follow-up" is enough. <!-- streview-comment:2442 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
