SEZ9 commented on PR #13060:
URL: https://github.com/apache/seatunnel/pull/13060#issuecomment-6991962239

   @zephyr45 thanks for the per-finding note for head `cf52689e`. Understood 
that this commit only deletes the `SinkContextProxy` override and its 
`MultiTableSinkWriterTest` case and does not touch Kafka or Spark code, so your 
notes still apply.
   
   Here is what you describe for the first three findings, which I will confirm 
against the diff:
   
   - **F1:** `validateRestoredStateOwner` and the modulo check were removed in 
`585f69b7`, so restore consumes whatever states the engine assigns and a Flink 
contiguous scale-down no longer throws. Tests: 
`KafkaSinkWriterTest#shouldFenceContiguouslyAssignedFlinkNamespacesAfterScaleDown`
 and `#shouldFenceEveryAssignedWriterNamespaceAfterScaleDown`.
   - **F2:** With `transaction_prefix` unset, each restored state is parsed 
against its own saved generated prefix and every assigned namespace is fenced 
(`585f69b7`). Test: `#shouldRestoreMixedGeneratedPrefixesAfterScaleDown`.
   - **F3:** A writer restored without state starts at sequence 1 in its 
current-index base namespace, and `initTransactions` on that ID fences an 
earlier attempt before the first send, without walking the namespace history 
(`d8143b58`, `b9ed7c12`). Tests: 
`#shouldReuseGeneratedPrefixWhenStatelessWriterRetries` and 
`#shouldNotWalkStatelessWriterTransactionHistory`.
   
   The copy of your note I am working from ends at "The documented 
`transaction.timeout.ms` boundary", so I may be missing the rest of that F3 
sentence and any notes on F4–F7. Those cover the Spark task-retry namespaces, 
the concurrent fencing of the legacy shared namespace, and the 
`transaction_prefix` option row and engine scope in the docs. If they are 
already in your comment, no action is needed. Otherwise, a commit and test name 
(or doc section) for each would help. These are the same points as before, not 
new requests.
   
   <!-- streview-comment:2427 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to