[
https://issues.apache.org/jira/browse/SENTRY-529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216469#comment-14216469
]
Lenni Kuff commented on SENTRY-529:
-----------------------------------
A few comments:
* Is it possible to make the Thrift changes in SENTRY-74 in a way so that they
are backwards compatible? For example, instead of changing the existing field
to a Set of TPrivileges could you could add a new optional field "Set
TPrivileges additionalPrivs" and just check if this field is set. I know the
protocol version was bumped, but if we can get around conditionally handling
protocol versions (which will now need to be done in every Sentry Thrift client
for every RPC) it would be ideal.
* Does this patch need to have protocol version checks?
* nit: fix indentation on line 164
Since this is breaking the build, it might be wise to get this fix in and
follow up with whatever Thrift changes are needed.
> [Unit Test]org.apache.sentry.tests.e2e.hdfs.TestHDFSIntegrationtestEnd2End
> test fails after SENTRY-74
> -----------------------------------------------------------------------------------------------------
>
> Key: SENTRY-529
> URL: https://issues.apache.org/jira/browse/SENTRY-529
> Project: Sentry
> Issue Type: Bug
> Reporter: Dapeng Sun
> Assignee: Dapeng Sun
> Priority: Blocker
> Attachments: SENTRY-529.patch
>
>
> {{SentryHDFSPlugin}} is using {{TSentryPrivilege}} in
> {{TAlterSentryRoleRevokePrivilegeRequest}} and
> {{TAlterSentryRoleGrantPrivilegeRequest}} , after SENTRY-74, it have changed
> to {{Set<TSentryPrivilege>}},adjust {{SentryHDFSPlugin}} for the change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
