liubao68 commented on a change in pull request #793: [SCB-718] If auto
discovery failed , will cause a dead cycle
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/793#discussion_r200616734
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/IpPortManager.java
##########
@@ -73,11 +88,45 @@ public IpPortManager(ServiceRegistryConfig
serviceRegistryConfig, InstanceCacheM
// we have to do this operation after the first time setup has already done
public void initAutoDiscovery() {
if (!autoDiscoveryInited &&
this.serviceRegistryConfig.isRegistryAutoDiscovery()) {
- instanceCacheManager.getOrCreate(REGISTRY_APP_ID,
Review comment:
Too complicated logic, you can just check if
instanceCacheManager.getOrCreate failed or not, if failed not set
autoDiscoveryInited = true and will work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
